Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spent BBs are no longer reloadable, add RGBB gun. #2046

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

whatston3
Copy link
Contributor

@whatston3 whatston3 commented Sep 21, 2024

About the PR

Edits the prototypes for BBs. Turns existing BBs into caseless cartridges that shoot spent BBs - the spent BBs now have the finite lifetime, and cannot be reloaded into the rifle.

Adds an RGB version of BBs, makes a box of them available as an emaggable item available in the NonLethalVend, and adds them as a rare item in the mail table. RGBBs do not have a point light until fired, when they will despawn in 30 seconds (or on most collisions).

Why / Balance

Reloading a spent BB into the gun would eventually despawn it and prevent the gun from firing again. Removing a BB from a box would cause it to eventually despawn.

RGBB? Funny.

How to test

  1. Set the probability for MailNFRGBBGun to 9999.
  2. Spawn, run mailnow.
  3. You should get an mail with an empty BB gun and a box of RGBBs.
  4. Cycle some RGBBs. They should not light up.
  5. Load an RGBB into the gun, it should load.
  6. Shoot some RGBBs. They should light up and despawn.
  7. Grab a shot RGBB, try to load it back into the gun. It should not load.
  8. Spawn a box of regular BBs.
  9. Cycle some BBs. They should not light up.
  10. Load some BBs into the gun. They should load.
  11. Shoot some BBs. They should not light up and eventually despawn.
  12. Grab a shot BB, try to load it back into the gun. It should not load.

Media

image

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • fix: Shot BBs now do not load into a BB gun.
  • add: RGBBs are now available from the mail and as an emagged item from the NonLethalVend.

@dvir001 dvir001 self-requested a review September 22, 2024 12:53
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants